Skip to content

Enable test_matmul_cuda UTs for ROCm #98797

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

Enable test_matmul_cuda UTs for ROCm #98797

wants to merge 1 commit into from

Conversation

BLOrange-AMD
Copy link
Contributor

@BLOrange-AMD BLOrange-AMD commented Apr 10, 2023 •
edited by pytorch-bot bot
Loading

test_file test_name test_class
test_matmul_cuda test_cublas_addmm_size_10000_cuda_bfloat16 (main.TestMatmulCudaCUDA)
test_matmul_cuda test_cublas_addmm_size_10000_cuda_float16 (main.TestMatmulCudaCUDA)
test_matmul_cuda test_cublas_addmm_size_10000_cuda_float32 (main.TestMatmulCudaCUDA)
test_matmul_cuda test_cublas_addmm_size_1000_cuda_bfloat16 (main.TestMatmulCudaCUDA)
test_matmul_cuda test_cublas_addmm_size_1000_cuda_float16 (main.TestMatmulCudaCUDA)
test_matmul_cuda test_cublas_addmm_size_1000_cuda_float32 (main.TestMatmulCudaCUDA)
test_matmul_cuda test_cublas_addmm_size_100_cuda_bfloat16 (main.TestMatmulCudaCUDA)
test_matmul_cuda test_cublas_addmm_size_100_cuda_float16 (main.TestMatmulCudaCUDA)
test_matmul_cuda test_cublas_addmm_size_100_cuda_float32 (main.TestMatmulCudaCUDA)

This PR is the same fix as #88888. Creating this new PR to sanitize the history.

cc @jeffdaily @sunway513 @jithunnair-amd @pruthvistony @ROCmSupport

@pytorch-bot
Copy link

pytorch-bot bot commented Apr 10, 2023 •
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/98797

Note: Links to docs will display an error until the docs builds have been completed.

❌ 2 Failures

As of commit ac70fc7:

NEW FAILURES - The following jobs have failed:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@pytorch-bot pytorch-bot bot added module: rocm AMD GPU support for Pytorch topic: not user facing topic category labels Apr 10, 2023
@BLOrange-AMD BLOrange-AMD mentioned this pull request Apr 10, 2023
Closed
@pruthvistony pruthvistony added ciflow/trunk Trigger trunk jobs on your pull request ciflow/periodic Trigger jobs ran periodically on master (periodic.yml) on the PR labels Apr 11, 2023
@pruthvistony pruthvistony self-requested a review April 11, 2023 00:13
pruthvistony
pruthvistony approved these changes Apr 11, 2023
View reviewed changes
Copy link
Collaborator

@pruthvistony pruthvistony left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes migrated from old approved PR#88888

@BLOrange-AMD
Copy link
Contributor Author

@pytorchbot drci

@jithunnair-amd
Copy link
Collaborator

jithunnair-amd commented Apr 13, 2023 •
edited
Loading

@malfet You already approved this PR's earlier copy, so this should be quick :) (sorry for the refile)

We have gone through the CI failures mentioned in the DrCI comment and none of them seem to be due to this PR:
BC Lint (gh: We don't see this failing in https://hud.pytorch.org/pr/98797
cuda11.7-py3.10-gcc7-sm86-periodic-dynamo-benchmarks / test (dynamic_aot_eager_timm, 1, 2, linux.g5.4xlarge.nvidia.gpu) (gh): Already failing in other PR/master jobs: https://hud.pytorch.org/failure/convit_base%2Cfail_to_run
linux-focal-rocm5.4.2-py3.8 / test (distributed, 1, 2, linux.rocm.gpu) (gh): Already failing in other PR/master jobs: https://hud.pytorch.org/failure/distributed%2Ffsdp%2Ftest_fsdp_core.py%3A%3ATestParityWithDDP%3A%3Atest_delayed_optim_step_offload_false_no_shard

@jithunnair-amd jithunnair-amd added rocm This tag is for PRs from ROCm team rocm priority high priority ROCm PRs from performance or other aspects labels Apr 13, 2023
@malfet
Copy link
Contributor

malfet commented Apr 13, 2023

@pytorchbot merge -ic

@malfet
Copy link
Contributor

malfet commented Apr 13, 2023

@jithunnair-amd please note, that ROCM distributed has been moved to periodic-unstable as it fails a lot in a un predictable manner

@pytorchmergebot
Copy link
Collaborator

Merge started

Your change will be merged while ignoring the following 2 checks: periodic / linux-focal-rocm5.4.2-py3.8 / test (distributed, 1, 2, linux.rocm.gpu), periodic / cuda11.7-py3.10-gcc7-sm86-periodic-dynamo-benchmarks / test (dynamic_aot_eager_timm, 1, 2, linux.g5.4xlarge.nvidia.gpu)

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@malfet malfet malfet approved these changes

@pruthvistony pruthvistony pruthvistony approved these changes

@jithunnair-amd jithunnair-amd jithunnair-amd approved these changes

@jeffdaily jeffdaily Awaiting requested review from jeffdaily

Assignees

No one assigned

Labels

ciflow/periodic Trigger jobs ran periodically on master (periodic.yml) on the PR ciflow/trunk Trigger trunk jobs on your pull request Merged merging module: rocm AMD GPU support for Pytorch open source rocm priority high priority ROCm PRs from performance or other aspects rocm This tag is for PRs from ROCm team topic: not user facing topic category

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@BLOrange-AMD @jithunnair-amd @malfet @pytorchmergebot @pruthvistony @pytorchbot